Fix overwriting initial hostname #23

Merged

antman merged 12 commits from fix-overriding-initial-hostname into main

2026-09-04 05:23:57 +00:00

antman commented

2026-09-03 09:09:02 +00:00

Owner

Motivation

Steps to Reproduce:

Configure a hostname other than localhost e.g. 45homelab
Install ServerManager
Patch the ServerManager config without changing hostname

Expected Result: The hostname should be unchanged (e.g. 45homelab)

Actual Result: The hostname reverts to localhost

When using ServerManager to install ApiServer, I discovered that patching the config causes ServerManager to set the hostname to '' which results in it reverting to the Linux default of localhost, which then broke all of the VM tests! 😅

Instead, when the application first starts up, it should set its config state to match the system's hostname.

Solution

I updated the hostname resource to only change the hostname value if it's being set to a truthy value. This should prevent it from setting the hostname to ''

I then also got the hostname resource to update the config service at startup. So it won't try to set the host name to '' in the first place.

I also had to get the hostname resource to update the config service every time it changed the hostname. Something feels wrong about the architecture here 🤔

### Motivation **Steps to Reproduce:** - Configure a hostname other than `localhost` e.g. `45homelab` - Install ServerManager - Patch the ServerManager config without changing `hostname` **Expected Result:** The hostname should be unchanged (e.g. `45homelab`) **Actual Result:** The hostname reverts to `localhost` When using ServerManager to install ApiServer, I discovered that patching the config causes ServerManager to set the hostname to `''` which results in it reverting to the Linux default of `localhost`, which then broke all of the VM tests! 😅 Instead, when the application first starts up, it should set its config state to match the system's hostname. ### Solution I updated the hostname resource to only change the hostname value if it's being set to a truthy value. This should prevent it from setting the hostname to `''` I then also got the hostname resource to update the config service at startup. So it won't try to set the host name to `''` in the first place. I also had to get the hostname resource to update the config service every time it changed the hostname. Something feels wrong about the architecture here 🤔

antman added 1 commit

2026-09-03 09:09:02 +00:00